Code review comment for lp:~parthm/bzr/no-chown-if-bzrlog-exists
Revision history for this message
| Parth Malwankar (parthm) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
One minor annoyance with that is that .bzr.log is created with the executable bit set due to O_CREAT. As per the open(2) man page:
The effective permissions are modified by the process's umask in the usual way: The permissions of the created file are (mode & ~umask).
On my system the mask is 022. I suppose we can do a chown specifically to unset executable bit. Thoughts?
Note: This isn't tested on Windows yet as I don't have a windows system available at the moment.