Code review comment for lp:~parthm/bzr/no-chown-if-bzrlog-exists

Revision history for this message
Martin Pool (mbp) wrote :

On 30 March 2010 16:37, Parth Malwankar <email address hidden> wrote:
> I have added permission of 0644 and tested it out.

No, it should actually be 0666. If the user sets their umask to allow
group-writable files we should respect that unless there is a good
reason.

--
Martin <http://launchpad.net/~mbp/>

« Back to merge proposal