Code review comment for lp:~patrick-regan/bzr/lp-quicktutorial

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Patrick Regan wrote:
>> I assume the issue is that the ".. [#]" can't be in the "::" block. Did you
>> do "make doc/en/mini-tutorial/index.html" and it worked for you? Because it
>> didn't work on PQM or on my local machine.
>
>
> I didn't actually (/me has a shameful look). I was at work on one of my
> breaks for that edit, so I didn't have an environment with docutils
> installed. I should have just waited to push it until I got home.
>
> Won't happen again.
>
> Pat
>

I wouldn't worry too much about "Won't happen again". Accidents happen,
and its why we have a PQM, a test suite, and code review in the first place.

Just a recommendation to make sure you check results before submission
as much is reasonable.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksX2cIACgkQJdeBCYSNAAPfTgCeIJp/HR9RDgIGlbyQ+hWj4nyK
UXcAoK/QNZmXabubEY5/gi3i5e7j4QU8
=9Dng
-----END PGP SIGNATURE-----

« Back to merge proposal