Code review comment for lp:~pfibiger/ubuntuone-storage-protocol/add-ssl-context

Revision history for this message
Elliot Murphy (statik) wrote :

This looks great. A minor style suggestion which you are free to ignore; changing the function signature to be

def get_ssl_context(verify=True):

would both enable keyword args and provide a sensible default. You'd need to change the condition inside the function to

if verify:
    <stuff>
else:
    the non verify path

but I think it would make callsites of this function nicer to read.

review: Approve

« Back to merge proposal