telephony-service

Merge lp:~phablet-team/telephony-service/fix_account_status_watching into lp:telephony-service/staging

  1. fix_account_status_watching
  2. Merge into staging
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 1253
Merged at revision: 1256
Proposed branch: lp:~phablet-team/telephony-service/fix_account_status_watching
Merge into: lp:telephony-service/staging
Diff against target: 26 lines (+5/-0)
2 files modified
libtelephonyservice/accountentry.cpp (+4/-0)
libtelephonyservice/accountlist.cpp (+1/-0)
To merge this branch: bzr merge lp:~phablet-team/telephony-service/fix_account_status_watching
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
Review via email: mp+321997@code.launchpad.net

Commit message

Fix watching the connection status changes and properly notify the changes to displayed accounts

Description of the change

Fix watching the connection status changes and properly notify the changes to displayed accounts

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good. thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libtelephonyservice/accountentry.cpp'
--- libtelephonyservice/accountentry.cpp 2017-03-22 19:04:13 +0000
+++ libtelephonyservice/accountentry.cpp 2017-04-05 13:54:08 +0000
@@ -240,6 +240,10 @@
240 SIGNAL(connectionStatusChanged(Tp::ConnectionStatus)),240 SIGNAL(connectionStatusChanged(Tp::ConnectionStatus)),
241 SIGNAL(connectionStatusChanged(Tp::ConnectionStatus)));241 SIGNAL(connectionStatusChanged(Tp::ConnectionStatus)));
242242
243 connect(mAccount.data(),
244 SIGNAL(connectionStatusChanged(Tp::ConnectionStatus)),
245 SIGNAL(connectedChanged()));
246
243 connect(mAccount.data(), &Tp::Account::parametersChanged,247 connect(mAccount.data(), &Tp::Account::parametersChanged,
244 this, &AccountEntry::parametersChanged);248 this, &AccountEntry::parametersChanged);
245249
246250
=== modified file 'libtelephonyservice/accountlist.cpp'
--- libtelephonyservice/accountlist.cpp 2017-03-22 19:04:13 +0000
+++ libtelephonyservice/accountlist.cpp 2017-04-05 13:54:08 +0000
@@ -121,6 +121,7 @@
121121
122 Q_EMIT accountChanged(account, account->active());122 Q_EMIT accountChanged(account, account->active());
123 Q_EMIT activeAccountsChanged();123 Q_EMIT activeAccountsChanged();
124 Q_EMIT displayedAccountsChanged();
124}125}
125126
126void AccountList::filterAccounts()127void AccountList::filterAccounts()

Subscribers

People subscribed via source and target branches

to all changes: