Code review comment for lp:~philip-peitsch/bzr/annotate-ghost-revs

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Philip Peitsch wrote:
> I've completed contributor agreement as requested, and cleaned up the diff by merging in latest bzr head. If you have any more tweaks you'd like, let me know :)
>
> P.S., I can't actually find any docs on the matter in launchpad, but is it better to resubmit a merge proposal or just re-use the existing one like this?

It has changed over time :). It used to be better to re-use one, because
otherwise you would lose comments.

However, it is now better to resubmit, as the comments get carried
across, and it resets any votes.

In this particular case, there is no need, as your changes are small,
and the diff will be updated.

I would also mention that we probably would want a test for this case,
to help prevent it from regressing.

I realize it is a bit hard to inject ghosts into the system, because it
is *designed* to not make it easy. (ATM, I think only bzr-svn is able to
label a text as coming from a ghost.)

So we can try to help you with writing that test, but we really should
have something so that we maintain support for it.

Did you at least test it interactively? (run 'bzr annotate' on something
you know has ghosts?)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwJCzIACgkQJdeBCYSNAAMRCwCgsFAMRXDuIjXM7uvFEAtryb0T
WlYAn2Hlhz6Iu8TYZYfjgVMxJP9ho7WE
=WdGm
-----END PGP SIGNATURE-----