Code review comment for lp:~philip-peitsch/quickly/apport-src-package-support

Revision history for this message
Philip Peitsch (philip-peitsch) wrote :

Definitely not my preferred way of integrating either... but it is better than a crash on the terminal :).

1. Sounds good... I have moved it
2. :S... whups! Fixed too
3. The difficulty is that I am essentially creating a new environment to pass to the subprocess call. sys.path and sys.putenv affect this current python process, but what I needed to do was change the env on the new one we're spawning. I had a quick poke and sys.path doesn't seem to have any affect on either env. Basically I believe this change is the only way of doing it... though if you have any other ideas I'm happy to try :)

4. I agree with regards to that. I'm thinking of improving the dialog so it simply displays a link to the +filebug url of the specified project that can be clicked on to test the functionality. Shouldn't be too much hassle... didn't want to put too many eggs into it however until you'd decided this approach was ok :). The next step is to figure out how to test apport integration hooks and things if possible...

« Back to merge proposal