Code review comment for lp:~pkgcrosswire/sword/get-orig-source

2009/4/20 Jonathan Marsden <email address hidden>:
> Jonathan Marsden has proposed merging lp:~pkgcrosswire/libsword/get-orig-source into lp:libsword.
>
> Requested reviews:
>    Дмитрий Ледков (dmitrij.ledkov)
>
> Per Roberto's suggestion, this
> adds a get-orig-source rule so
> we can automatically repack the
> SWORD source tarball, removing
> the zlib and regex files.

I'm against this. Both zlib and regex are DFSG-free and are included
in Debian main, hence there are no restrictions from legal point of
view for debian. Yes, we don't need them (debian policy) but removal
of just zlib and regex do not outweigh the ability to check checksums
of the upstream tarball.

A patch will do it just fine to remove these files before we do
anything giving the same result, but the checksums can be still
checked.

And the preferred solution IMHO is to work with upstream on this issue.

--
With best regards

Dmitrijs Ledkovs (for short Dima),
Ледков Дмитрий Юрьевич