Code review comment for lp:~rackspace-titan/nova/openstack-api-version-split

Revision history for this message
Eric Day (eday) wrote :

40: nova.context should not hold anything openstack API specific. You probably want to store version in the req.environ dict if you need it somewhere.

592: how did that get in there? :)

Overall, I'm not sure I agree with the approach. It versions the serialization, but not the controllers. I'm wondering if we should instead use the old serialization conventions and just make versioned controllers that would call the correct one. You would then specify versioned controllers in the paste config which seems a bit more straightforward.

review: Needs Fixing

« Back to merge proposal