Code review comment for lp:~rackspace-titan/nova/openstack-api-version-split

Revision history for this message
Eric Day (eday) wrote :

39: might want something more specific than 'version' for the var, as I could see this conflicting with other things. Something like nova.api.openstack.version would have less chance of conflicting.

256,296: Shouldn't use python3 formatting, we're still supporting at least 2.5 afaik and this isn't consistent with the rest of the code base

Need license headers on all the new files.

As I mentioned on IRC, I think the get_view_builder functions should go away once the controllers are versioned since you can call the version directly. This won't block once these other issues are fixed though.

review: Needs Fixing

« Back to merge proposal