OpenStack Compute (nova)

Code review comment for lp:~rackspace-titan/nova/openstack-api-version-split

  1. openstack-api-version-split
  2. Merge into trunk
Revision history for this message
Brian Lamar (blamar) wrote :

Line 150: except exception.NotFound:

Potentially nitpicky, which one of the three statements in the try/except can raise the NotFound exception? Can we just put the one line which can raise the exception in there?

Line 518: req.environ['api.version'] = '1.0'

Should this be 'openstack.api.version' or something more specific to OpenStack?

review: Needs Fixing

« Back to merge proposal