Code review comment for lp:~rackspace-titan/nova/openstack-api-version-split

Revision history for this message
Brian Waldon (bcwaldon) wrote :

> Line 150: except exception.NotFound:
>
> Potentially nitpicky, which one of the three statements in the try/except can
> raise the NotFound exception? Can we just put the one line which can raise the
> exception in there?
>

Fixed.

>
> Line 518: req.environ['api.version'] = '1.0'
>
> Should this be 'openstack.api.version' or something more specific to
> OpenStack?

In our chat, we didn't have a good enough reason to make these versions api-specific. Leaving it alone for now.

« Back to merge proposal