Code review comment for lp:~rick-rickspencer3/lazr.restfulclient/add_gaurd_for_None_to_eq_functions

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Looks great guys!

At first I was confused about the purpose of the documentation:

> +An entry is never equal to None.
> +
> + >>> recipe == None
> + False

as recipe is obviously not None in the documentation, but then realised this is really showing that we don't fall over when comparing with None right? In which case, it probably belongs in a unit test in src/lazr/restfulclient/tests (or explicitly say here 'An entry can be compared with None without blowing up' ;), but not sure how useful that is as documentation)? But I'll leave that up to you Leonard.

Thanks!

review: Approve (code)

« Back to merge proposal