Code review comment for lp:~rls/bzr/transport-link-and-symlink-support

Revision history for this message
Martin Packman (gz) wrote :

I'd prefer this style:

+ if osutils.hardlinks_good()
+ def link(self, source, link_name):
...

Over the current:

+ def link(self, source, link_name):
...
+ except AttributeError:
+ raise errors.TransportNotPossible("Hardlinks are not supported on %s" % self)

review: Needs Fixing

« Back to merge proposal