Code review comment for lp:~rls/bzr/transport-link-and-symlink-support

Revision history for this message
Neil Santos (rls) wrote :

> + st = t.stat(link_name)
> + self.failUnlessEqual(st[ST_NLINK], 2)
>
> Good; I think there might be a TestCase method to check they're linked
> to each other.

Hrm... I didn't find such a method per se, but I didn't find a couple of tests using osutils' readlink(), which should be good enough for LocalTransport, as well as Paramiko's SFTP's readlink(). I'll go ahead and add a readlink() to Transport; let me know how it looks.

« Back to merge proposal