Code review comment for lp:~rls/bzr/transport-link-and-symlink-support

Revision history for this message
Martin Packman (gz) wrote :

> > I'd prefer this style:
> >
> > + if osutils.hardlinks_good()
> > + def link(self, source, link_name):
> > ...
>
> Implemented. ...

Ah, I also meant this to go for the `symlink` function on the same object, with `osutils.has_symlinks` as the definition-time check. The point being, you know what the module is loaded if the python implementation has a (?:sym)link function, so don't need to check within the call itself. You do still need to check for other errors, as the specific filesystem/path may not support the given operation.

Not sure what the main Martin meant with his code fragment on the same topic though.

« Back to merge proposal