Code review comment for lp:~robru/gwibber/expiry
Revision history for this message
| Barry Warsaw (barry) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
On Sep 11, 2012, at 08:10 PM, Barry Warsaw wrote:
>Also, IME expiry arithmetic is easier to follow if it's done slightly
>differently. With the above code, and the following condition, you have to
>sort of stop and think about the meaning. If instead you *added* 4 weeks to
>the file's mtime, and then compared that to see if it was greater than today,
>it's typically easier to follow the logic. I've done it both ways over the
>years, and the latter just seems to be more readable.
Yeah, never mind. What you wrote is fine.