Code review comment for lp:~rockstar/launchpad/branch-index-redesign

Revision history for this message
Paul Hummer (rockstar) wrote :

Hi Aaron-

  First of all, I apologize for the size of this branch. I couldn't see a sane
way of splitting it up.

  This branch is a long time coming. It's the re-design of the branch index
page. I'm 99% sure I got all the failing tests and fixed them (it's gone
through ec2 at least 5 times). While working on that though, I found that our
tests are far too dependent on the html layout of pages, instead of the actual
content. I plan to fix this soon by moving a lot of what we're testing out
into unittests (and kill the page tests).

  There are some flakes errors being raised about not being able to import lazr
packages, but I think flakes is just stupid.

 reviewer abentley

Cheers,
Paul

« Back to merge proposal