Code review comment for lp:~rockstar/launchpad/branch-index-redesign

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status approved

Paul Hummer wrote:
> This branch is ...the re-design of the branch index
> page.

(The review diff is wildly inaccurate.)

As discussed on IRC, please make the following changes:

Add enabled_with_permission to edit_import.

Please remove the lolspeak comment from lib/lp/code/browser/configure.zcml

Please stop hiding merges into import branches.

Please remove the outer div of the nested tal:condition from the top of
branch-management.pt

Aside from that, this is good to land.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqzszwACgkQ0F+nu1YWqI2rqwCeLvmgAsZCRqnTQRc4ApBIXgC+
XZUAn1yJBLbVkHvmy1/9HVy2rTvHkJZh
=jkPY
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal