Launchpad itself

Code review comment for lp:~rockstar/launchpad/branch-index-redesign

  1. branch-index-redesign
  2. Merge into devel
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Hi Paul,

This looks nice. I only have two small changes that I would like.

 1. Move the public/private info to the top of the sidebar, so its location is more similar to bugs and teams.
 2. For private branches, add a second line to the public/private box to explain what the privacy means. For example, private teams now say "Viewable by team members", and I assume the branch subscriber and owner can view a private branch.

-Edwin

review: Approve (ui)

« Back to merge proposal