Code review comment for lp:~rockstar/launchpad/branch-index-redesign

On Sat, Sep 19, 2009 at 12:50 AM, Paul Hummer <email address hidden> wrote:
> Paul Hummer has proposed merging lp:~rockstar/launchpad/branch-index-redesign into lp:launchpad/devel.
>
> Requested reviews:
>    Aaron Bentley (abentley)
>
> Hi Aaron-
>
>  First of all, I apologize for the size of this branch.  I couldn't see a sane
> way of splitting it up.
>
>  This branch is a long time coming.  It's the re-design of the branch index
> page.  I'm 99% sure I got all the failing tests and fixed them (it's gone
> through ec2 at least 5 times).  While working on that though, I found that our
> tests are far too dependent on the html layout of pages, instead of the actual
> content.  I plan to fix this soon by moving a lot of what we're testing out
> into unittests (and kill the page tests).
>
>  There are some flakes errors being raised about not being able to import lazr
> packages, but I think flakes is just stupid.
>
>  reviewer abentley

I've got a few questions that I can't figure out from the screenshots.

  - If it's a mirrored branch, and the mirror has failed, then what
does the page look like?

  - Where does the "Branch content" link go to? I hope it's to file
browsing on loggerhead

  - I think it's a negative that there's absolutely no information
about the last revision on this page.

  - There should also be a link to the series of the branch, if the
branch is linked to a series.

  - How do I delete a branch?

  - How do I change the status?

My flight's leaving now, but I'd really like to talk about this
further. Sorry for being so terse.

jml