Code review comment for lp:~rockstar/launchpad/branch-upgrade-out-of-place

Hi Michael-

  So, this branch is basically a re-write of what I had yesterday, since I
wasn't using transports. Aaron showed me the way, and so this branch is a lot
cleaner. I also didn't change any tests, just made sure the old ones passed.
I did this because I thought the tests were getting too introspective into the
implementation. Basically, I had the job split up into _pre_upgrade, _upgrade,
and _post_upgrade methods, and were testing that each method did what it was
supposed to. This led to madness, IMHO. If you think I'm wrong, I'd be more
than happy to change it back.

  I also fixed some lint that came up in the lint report. The lint warnings
about not finding lazr are craziness.

  To test: bin/test -vvc lp.code.model.tests.test_branchjob TestBranchUpgradeJob

  I've never really had to dive this far into the bzrlib stuff before, so I
expect there are probably better ways to do what I'm doing. I'm all ears.

 reviewer mwhudson

Cheers,
Paul