Code review comment for lp:~rockstar/launchpad/code-import-cvs-oops

Revision history for this message
Paul Hummer (rockstar) wrote :

Hi Henninge-

  This branch fixes bug #306290 - The CVS root validator uses the CVSRoot class
from cscvs. It takes a CVS root string and parses it into a class using a
regex. It's regex is built to be more permissable than the code import system
wants. Basically, we only want to import using the pserver. I added a test to
verify that it finds the right properties, and to raise a
LaunchpadValidationError when the pserver is left off.

  To test, run bin/test -vvt stories/codeimport/xx-create-codeimport.txt

  While I was there, I also converted the test the ReST.

 reviewer henninge

Cheers,
Paul

« Back to merge proposal