Code review comment for lp:~rockstar/launchpad/codereview-js

Revision history for this message
Martin Albisetti (beuno) wrote :

Hi Paul,

This branch looks great, it feels quite polished.

There are two issues I wanted to ask you about:

- The escape key doesn't seem to work for me on this overlay. Any idea why?
- The optional type field feels odd. I think it is because it's not clear what to click to accept, and since the person is above that field, then it's even weirder to have to click on top to save something on the bottom. My feeling is that this should have an accept button come up once you've clicked on a person, to confirm it, and give you time to fill-in the review type.
What do you think?

review: Needs Information (ui)

« Back to merge proposal