Code review comment for lp:~rockstar/launchpad/fix-code-windmill-tests

Revision history for this message
Paul Hummer (rockstar) wrote :

This branch fixes a couple of windmill tests that were broken, as well as a breakage in my progressive enhancement changes that were introduced with my subscription refactoring.

The subscription refactoring apparently had a letter deleted accidentally before landing that ended up causing some of the Windmill tests to fail because the javascript was erroring out (and javascript doesn't deal with errors very well.) Also, apparently in some merge from trunk into my subscription refactoring branch, my changes got thrown away (probably due to human error in conflict resolution). I introduced a page test to make sure this won't happen again. The rest of the changes were minor changes that got through before Windmill was required in the test run, and will no longer break now that it is part of the test run.

Also, while fixing broken tests, I took the liberty of cleaning up the bug-branch link windmill test to remove repeatability, as well as clear up some copy-n-paste errors.

« Back to merge proposal