Merge lp:~rockstar/launchpad/fix-ensure-login into lp:launchpad
Proposed by
Paul Hummer
Status: | Merged |
---|---|
Approved by: | Edwin Grubbs |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~rockstar/launchpad/fix-ensure-login |
Merge into: | lp:launchpad |
Diff against target: |
13 lines 1 file modified
lib/canonical/launchpad/windmill/testing/lpuser.py (+2/-1) |
To merge this branch: | bzr merge lp:~rockstar/launchpad/fix-ensure-login |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Edwin Grubbs (community) | code | Approve | |
Review via email: mp+13373@code.launchpad.net |
To post a comment you must log in.
Hi Edwin-
When BaseWindmillLayer tests came about, we started consolidating our test
functions into TestCase classes. In the code team, we noticed that if you
have more than one test method in the same class, subsequent ensure_login calls
fail.
Upon further inspection, it looks like waitsForPageLoad doesn't always work
right (I'll chase this with the Windmill folks). The fix for this is to make
the test wait for the actual element it needs instead.
The way I was tested is this:
for i in `seq 5`; CodeWindmillLay er test_branch_ subscriptions
do
bin/test -v --layer=
done
Basically, run the tests 5 times. I knew I was done when there was no failure.
Cheers,
Paul