Code review comment for lp:~rockstar/launchpad/fix-ensure-login

Hi Edwin-

  When BaseWindmillLayer tests came about, we started consolidating our test
functions into TestCase classes. In the code team, we noticed that if you
have more than one test method in the same class, subsequent ensure_login calls
fail.

  Upon further inspection, it looks like waitsForPageLoad doesn't always work
right (I'll chase this with the Windmill folks). The fix for this is to make
the test wait for the actual element it needs instead.

  The way I was tested is this:

for i in `seq 5`;
do
bin/test -v --layer=CodeWindmillLayer test_branch_subscriptions
done

  Basically, run the tests 5 times. I knew I was done when there was no failure.

Cheers,
Paul