Code review comment for lp:~rockstar/launchpad/recipe-index-redux

Revision history for this message
Tim Penhey (thumper) wrote :

IRecipiesForPerson instead of ISourcePackageRecipeSet

so the __init__ should take a person, not a recipe

SourcePackageRecipeSetBreadcrumb needs a blank line after it. Actually lets merge the two classes as the class's entire purpose is to provide a breadcrumb, so it should just inherit from Breadcrumb, and provide the other interface. That way it doesn't need an adapter.

« Back to merge proposal