Code review comment for lp:~rockstar/launchpad/unsupported-series-recipe-api

get_buildable_distroseries_set could use a docstring - just a little one noting why its not doing the search at the sql layer perhaps?

+ new_distroseries = archive.distribution.getSeries('hoary')

doesn't seem to use your helper function - could it?

copy=n=paste mismatch:

294 + def test_requestBuildRejectUnsupportedDistroSeries(self):
295 + """Build requests are rejected if they exceed quota."""

this :

369 + second_distroseries = \
370 + self.factory.makeSourcePackageRecipeDistroseries("hoary")

is that a change to use another non-sample-data-tied helper?

Generally fine to land, consider these recommendations.

Thanks,
Rob