Code review comment for lp:~rockstar/launchpad/upgrade-ui

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Hi Paul,

This branch looks good. Since you have other rounds of reviews to go with this, I am just going to mention the UI changes that might make sense but not require them as part of this branch.

 merge-approved

1. I think moving the "Upgrade this branch" to the action menu in the sidebar would make it easier to find, but I could see how you might want to make it even more prominent than that.
2. On the +upgrade page, it would be nice to alert the user that they may have to upgrade their installation of bzr.

-Edwin

review: Approve (code)

« Back to merge proposal