LAZR Javascript Library

Merge lp:~rockstar/lazr-js/overlay-width into lp:lazr-js

  1. overlay-width
  2. Merge into toolchain
Proposed by Paul Hummer
Status: Merged
Merged at revision: 181
Proposed branch: lp:~rockstar/lazr-js/overlay-width
Merge into: lp:lazr-js
Diff against target: 52 lines (+6/-6)
1 file modified
src-js/lazrjs/overlay/assets/skins/sam/pretty-overlay-skin.css (+6/-6)
To merge this branch: bzr merge lp:~rockstar/lazr-js/overlay-width
Reviewer Review Type Date Requested Status
Tim Penhey (community) Approve
Review via email: mp+33478@code.launchpad.net

Description of the change

This branch fixes two bugs with the overlay - first, the overlay can now grow depending on its contents, and second, the overlay doesn't enforce a font-family anymore.

I figured I would fix these two bugs before I work through the wizard widget.

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Looks fine to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src-js/lazrjs/overlay/assets/skins/sam/pretty-overlay-skin.css'
--- src-js/lazrjs/overlay/assets/skins/sam/pretty-overlay-skin.css 2010-05-07 17:40:07 +0000
+++ src-js/lazrjs/overlay/assets/skins/sam/pretty-overlay-skin.css 2010-08-24 01:41:42 +0000
@@ -8,13 +8,13 @@
8 padding: 0;8 padding: 0;
9 margin: 0;9 margin: 0;
10 left: 405px;10 left: 405px;
11 width: 402px;11 min-width: 40%;
12}12}
1313
14.yui3-pretty-overlay #yui3-pretty-overlay-modal {14.yui3-pretty-overlay #yui3-pretty-overlay-modal {
15 margin: 7px 0px;15 margin: 7px 0px;
16 padding: 0;16 padding: 0;
17 font: normal normal 12px/normal sans-serif;17 font: normal normal 12px/normal;
18 color: #484848;18 color: #484848;
19 background: #fff;19 background: #fff;
20}20}
@@ -22,7 +22,7 @@
22.yui3-pretty-overlay .close {22.yui3-pretty-overlay .close {
23 margin: 0;23 margin: 0;
24 padding: 0 5px;24 padding: 0 5px;
25 font: normal normal 10px/normal sans-serif;25 font: normal normal 10px/normal;
26 color: #484848;26 color: #484848;
27 background: #fff;27 background: #fff;
28}28}
@@ -42,7 +42,7 @@
4242
43.yui3-pretty-overlay #yui3-pretty-overlay-modal h1,43.yui3-pretty-overlay #yui3-pretty-overlay-modal h1,
44.yui3-pretty-overlay #yui3-pretty-overlay-modal h2 {44.yui3-pretty-overlay #yui3-pretty-overlay-modal h2 {
45 font: normal normal 18px/normal sans-serif;45 font: normal normal 18px/normal;
46 color: #000;46 color: #000;
47 text-indent: 15px;47 text-indent: 15px;
48 margin: 0;48 margin: 0;
@@ -51,13 +51,13 @@
5151
52.yui3-pretty-overlay #yui3-pretty-overlay-modal h2 {52.yui3-pretty-overlay #yui3-pretty-overlay-modal h2 {
53 height: 30px;53 height: 30px;
54 font: normal normal 18px sans-serif;54 font: normal normal 18px;
55 color: #000;55 color: #000;
56}56}
5757
58.yui3-pretty-overlay #yui3-pretty-overlay-modal .steps h2 {58.yui3-pretty-overlay #yui3-pretty-overlay-modal .steps h2 {
59 height: 30px;59 height: 30px;
60 font: normal normal 14px/30px sans-serif;60 font: normal normal 14px/30px;
61 color: #666;61 color: #666;
62}62}
6363

Subscribers

People subscribed via source and target branches