Merge lp:~rodrigo-moya/ubuntu/natty/nautilus/fix-718098 into lp:~ubuntu-desktop/nautilus/ubuntu

Proposed by Rodrigo Moya
Status: Merged
Merged at revision: 119
Proposed branch: lp:~rodrigo-moya/ubuntu/natty/nautilus/fix-718098
Merge into: lp:~ubuntu-desktop/nautilus/ubuntu
Diff against target: 42 lines (+21/-1)
3 files modified
debian/changelog (+7/-0)
debian/patches/96_no-null-in-g-str-hash.patch (+13/-0)
debian/patches/series (+1/-1)
To merge this branch: bzr merge lp:~rodrigo-moya/ubuntu/natty/nautilus/fix-718098
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Review via email: mp+50734@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Looks fine, thanks! Please forward/commit it upstream as well, though.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-01-16 11:39:50 +0000
+++ debian/changelog 2011-02-22 12:42:02 +0000
@@ -1,3 +1,10 @@
1nautilus (1:2.32.2.1-0ubuntu6) UNRELEASED; urgency=low
2
3 * debian/patches/96_no-null-in-g-str-hash.patch:
4 - Added patch to avoid crashing on g_str_hash (LP: #718098)
5
6 -- Rodrigo Moya <rodrigo.moya@canonical.com> Tue, 22 Feb 2011 13:27:37 +0100
7
1nautilus (1:2.32.2.1-0ubuntu5) natty; urgency=low8nautilus (1:2.32.2.1-0ubuntu5) natty; urgency=low
29
3 * 04_additional_marge_for_unity.patch:10 * 04_additional_marge_for_unity.patch:
411
=== added file 'debian/patches/96_no-null-in-g-str-hash.patch'
--- debian/patches/96_no-null-in-g-str-hash.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/96_no-null-in-g-str-hash.patch 2011-02-22 12:42:02 +0000
@@ -0,0 +1,13 @@
1diff --git a/libnautilus-private/nautilus-icon-info.c b/libnautilus-private/nautilus-icon-info.c
2index f39ad42..e23413e 100644
3--- a/libnautilus-private/nautilus-icon-info.c
4+++ b/libnautilus-private/nautilus-icon-info.c
5@@ -293,7 +293,7 @@ loadable_icon_key_free (LoadableIconKey *key)
6 static guint
7 themed_icon_key_hash (ThemedIconKey *key)
8 {
9- return g_str_hash (key->filename) ^ key->size;
10+ return g_str_hash (key->filename ? key->filename : "") ^ key->size;
11 }
12
13 static gboolean
014
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-01-11 16:47:28 +0000
+++ debian/patches/series 2011-02-22 12:42:02 +0000
@@ -13,4 +13,4 @@
1390_git_audio_preview_url.patch1390_git_audio_preview_url.patch
14#91_correct_rgba_use.patch14#91_correct_rgba_use.patch
1595_no-initial-fade.patch1595_no-initial-fade.patch
161696_no-null-in-g-str-hash.patch

Subscribers

People subscribed via source and target branches

to all changes: