Code review comment for lp:~rodrigo-moya/ubuntuone-client/use-sso-in-u1-prefs

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

For the constants use those in ubuntuone/clientdefs.py.

Please fix the docstrings "Helper that handles the REST response." (and the similar ones).

This needs to use APP_NAME instead of 'ubuntuone': iface.clear_token('ubuntuone'.
This also: + if app_name == "Ubuntu One":

Remove + print "Got credentials"
Remove _() for log messages.

review: Needs Fixing

« Back to merge proposal