Code review comment for lp:~rodrigo-moya/unity/fix-740360

Revision history for this message
Alejandro PiƱeiro (apinheiro) wrote :

Ok, this seems to work now, as I was not able to reproduce the bug. Some brief comments:

* Little nitpick on lines 41-44: it seems that the indentation are not homogeneous

* Some things to take into account (for other bug, but writing here to not forget that)
   * When you select the volume indicator it exposes the level
      * But if you move down, when the volume bar is selected no sound is exposed
      * The same when you select the play buttons
      * In general: some of those entries are not exposing
   * On the calendar item: if you move down, and enter the calendar, I didn't find any way to close that window. Moving left-right moves on the calendar, and press Esc doesnt close it. In the same way you can't press alt+f1 or other unity keybinding.
      * In summary you "get trapped" on the calendar

But as I said, those are issues for other bugs. Approving the branch

review: Approve

« Back to merge proposal