Code review comment for lp:~rom1-chal/bzr-builder/reporting_conflict_from_merge

Revision history for this message
Martin Pool (mbp) wrote :

On 19 July 2010 18:43, Romain Chalumeau <email address hidden> wrote:
> OK, i understand.
>
> What do you think of the approach of getting in the exception an array
> of revision objects in conflict. In these objects, we can find any
> information necessary to build a reporting on the conflict status
> (revno, revid, dates, files, developers, etc...)
>
> As the exception is typed, i can easily extend the build command to
> catch the branch and revisions in conflict, and so customize my
> reporting. The bzr-builder can keep a standard exception msg.
>
>
>
>
> For a future feature, I was thinking about a report template in
> a .bazaar directory for instance. If none is present, the standard error
> is reported. If a template is present, it replaces the values for the
> revisions in conflict.
>
> Keywords might be something like :
> revfrom_no / revto_no, revfrom_author / revto_author, etc...

I think this basic concept would be useful to have within bzr itself.

> An option --email-report may exist to automatically to email the report
> to the one launching the command and the concerned developers.

I think we should have a post-merge-conflicts hook, which can be
configured in a particular context to send mail to whoever.
--
Martin

« Back to merge proposal