Code review comment for lp:~rom1-chal/bzr/post_checkout_hook

Hi Jelmer,

You're right on the recipe. In fact, I use a forked bzr-builder to run it through jenkins and which includes reporting and a way not to stop at the first conflict, but instead tries to merge the most of the recipe : the conflicts are reported (and reverted of course). So far, it is too specific to be proposed to merge as is.
But you gave me an other view on how to reproduce conflicts, thanks. So true, i can avoid using a post_checkout hook for that case.

Anyhow, it seems to me that a checkout hook helps in better handling some existing plugins without wrapping the builtins command. For instance, look at the externals plugin : it can be handled with a checkout hook rather than overload the checkout command.
I also see a usage as checkouting anywhere but using a configured and unique shared repository (something like bzrtools.cbranch, but with builtins commands).
Or a way to use the bzr-builder : when you branch or checkout a branch containing a recipe file, it launches the build from the checkouted file.
It can also be used to configure on the fly some development environments (automated configuration to test the code, automated downloads of components like in launchpad code, etc...).

Well, i see some usages to ease and automate the developpers work and which needs to deal with the working tree files.

You're right about the master_branch. I also agree on tree.last_revision. I will change those.

Rgds/Romain