Code review comment for lp:~rom1-chal/bzr/post_checkout_hook

Revision history for this message
Romain Chalumeau (rom1-chal) wrote :

Hi,

I updated the code regarding the comments from jelmer.
I did not succeed in creating a unit test for the case where the branch is updated while checkouting it (comment about race condition). In other words, i didn't succeed in having the test failed with the race condition.
So i updated the code with tree.last_revision because I think this case could occur when the master branch is updated while creating the working tree. But no test with it...

Rgds/Romain

review: Needs Resubmitting

« Back to merge proposal