Code review comment for lp:~ryorke/bzr/140563-optparse-barfs-on-unicode

Revision history for this message
Rory Yorke (ryorke) wrote :

OK, so after some tests, I have:

| Platform | test_nonascii_optparse | "bzr st -ä" gives |
|-------------+------------------------+---------------------------------------------|
| Lin py24 | fail | ERROR: no such option: -ä |
| Lin py25-26 | pass | ERROR: Only ASCII permitted in option names |
| Win py24 | error | ERROR: no such option: -ä |
| Win py27 | pass* | ERROR: Only ASCII permitted in option names |

On Windows/Python 2.7, four of the five tests are skipped; each one's for a
different user encoding. This seems to be unrelated to command options, but
is something to do with a path:

  Unable to represent path u'\u0422\u0435\u0441\u0442' in terminal encoding
  "cp437 " (even though it is valid in filesystem encoding "mbcs"))

On Windows/Python 2.4, the test errors out spectacularly with a
UnicodeEncodeError (assume this is what you referred to).

I'm not sure what to do. One possibility is allowing either error form ("only
ascii" and "no such option"); in this case the test passes everywhere.

I don't understand your suggestion. What's the "nix path"?

« Back to merge proposal