Launchpad itself

Code review comment for lp:~salgado/launchpad/bug-495544

  1. bug-495544
  2. Merge into db-devel
Revision history for this message
Henning Eggers (henninge) wrote :

Thanks for fixing this!

As discussed on IRC, please use assertContentEqual where appropriate and order assert parameters as "expected, observed" (this reviewer likes that better ;). Also, please rename the two test cases in the file as TestZopelessTransactionManagerNoLayer and TestZopelessTransactionManager.

Cheers,
Henning

review: Approve (code)

« Back to merge proposal