Launchpad itself

Code review comment for lp:~salgado/launchpad/cached-menus

  1. cached-menus
  2. Merge into devel
Revision history for this message
Curtis Hovey (sinzui) wrote :

Hi Salgado.

This was an interesting problem.

As we agreed on IRC, the facet menu test can be removed because lazr/doc/menus.txt also tests the feature, and it clearly tests it the right way. I supplied a patch that moves the absolute URL test changes into lazr/doc/menus.txt. The launchpad/doc/menus.txt is and old and bad test that we are trying to remove.

Your implementation and real test is fine.

review: Approve (code)

« Back to merge proposal