Code review comment for lp:~salgado/tomdroid/sync-ui

Revision history for this message
Rodja (trappe) wrote :

It is great to get rid of the templates but...

1. The tests are not passing if there are already notes in the database (see two-way-branch for an setUp/tearDown example).

2. Rather then introducing a new member to flag a note as "template" I would suggest to seach for the template tag each time isNotebookTemplate() is called. Performance is not an issue, but later refactorings will be harder with each new member variable.

3. Similar to the second remark, I would sooner see a row for all the tags changing the database when ever we feel about supporting a new tag.

« Back to merge proposal