Tomdroid

Code review comment for lp:~salgado/tomdroid/sync-ui

sync-ui
Merge into sync-ui

Revision history for this message

Guilherme Salgado (salgado) wrote on 2010-09-17:

On Fri, 2010-09-03 at 04:29 +0000, Olivier Bilodeau wrote:
> Hi guys,
>
> I'm a bit concerned when hearing about the XML vs JSON tags.. In the
> end, aren't they both strings (ex: system:template or
> system:notebook:bookname)? Wait, as I write this (noticing the

Yes, they're the same thing; I don't know what I had in mind when I
wrote that.

> <bookname> related to the notebook addin) I see tons of potential
> problems with a rigid SQL approach..

Well, that could be extrapolated to the rest of tomdroid, no? I mean,
is a relational database the right thing to store tomboy notes?

>
> - A multi to multi SQL approach would be ugly as hell (one entry per
> <bookname>) but then what about nested xml in the tag or attributes in
> the xml node.. where would they end up?
> - A list of enabled/disabled tags represented in a row of a note as a
> packed binary would not handle additional data either.. and would be
> more coupled with Tomdroid's version..
>
> What do we do here? <buzzword>Schema-less database?</buzzword> I'll
> let you guys think about that. Do not hesitate to bring this to the
> -dev list if you feel it deserves to.

We could use CouchDB (http://www.couch.io/android) for 2.1 and 2.2, but
not for previous versions. Do you know of any alternatives?

> On the performance / potential power-saving topic:
> Until we have benchmark evidence showing it's not efficient I would
> opt for simpler code and less db maintenance. I don't plan to do auto
> db upgrade for 0.4 but just drop the db because no notes can be
> created locally yet. Someone could work on that if required though.

IMHO, that's not necessary as long as notes are read-only in tomdroid.

I'd really like to keep working on this and do some experiments, but I
won't be able to do that before November as I'm recovering from a
surgery and have my left arm in a sling, so unless anybody else wants to
move this forward, I think it won't be included in 0.4

--
Guilherme Salgado <https://launchpad.net/~salgado>

On Fri, 2010-09-03 at 04:29 +0000, Olivier Bilodeau wrote:
> Hi guys,
> 
> I'm a bit concerned when hearing about the XML vs JSON tags.. In the
> end, aren't they both strings (ex: system:template or
> system:notebook:bookname)? Wait, as I write this (noticing the

Yes, they're the same thing; I don't know what I had in mind when I
wrote that.

>  <bookname> related to the notebook addin) I see tons of potential
> problems with a rigid SQL approach..

Well, that could be extrapolated to the rest of tomdroid, no?  I mean,
is a relational database the right thing to store tomboy notes?

> 
> - A multi to multi SQL approach would be ugly as hell (one entry per
> <bookname>) but then what about nested xml in the tag or attributes in
> the xml node.. where would they end up?
> - A list of enabled/disabled tags represented in a row of a note as a
> packed binary would not handle additional data either.. and would be
> more coupled with Tomdroid's version..
> 
> What do we do here? <buzzword>Schema-less database?</buzzword> I'll
> let you guys think about that. Do not hesitate to bring this to the
> -dev list if you feel it deserves to.

We could use CouchDB (http://www.couch.io/android) for 2.1 and 2.2, but
not for previous versions.  Do you know of any alternatives?

IMHO, that's not necessary as long as notes are read-only in tomdroid.

-- 
Guilherme Salgado <https://launchpad.net/~salgado>

« Back to merge proposal