Code review comment for lp:~serge-hallyn/ubuntu/maverick/qemu-kvm/update-to-12.4

Thanks for creating a merge proposal.

Looking at the last changelog entry for the last new upstream release (0.12.3+noroms-0ubuntu1) you'll notice that the upstream tarball cannot be used directly as it contains some binary BIOS roms whose sources are not available. Thus we need to repack the upstream tarball before importing it into the archive - thus the +noroms appended to the upstream revision. This is why a bunch of new binary files under pc-bios/ have been added to the branch (line 2326).

There should only be one changelog entry with the revision set to 0.12.4+noroms-0ubuntu1 (ie without ~hallyn1 - but I guess you already knew about that ;)). For the point "Removed the capslock patch..." I'd add a reference to the LP bug number using the notation: LP: #DDDDDD

In debian/rules (line ) what does line 1408 mean?:

  , := ,