I thought it is not necessary to have self.commit_message.strip().encode('utf-8').
You can refer below two pieces of code.
in bzrlib/plugins/launchpad/cmds.py, the option 'message' is type=unicode.
in bzrlib/plugins/launchpad/lp_propose.py, self.call_webservice already use commit_message=self.commit_message.
bzrlib/plugins/launchpad/cmds.py
class cmd_lp_propose_merge(Command):
...
takes_options = [Option('staging', help='Propose the merge on staging.'), Option('message', short_name='m', type=unicode, help='Commit message.'), Option('approve', help=('Mark the proposal as approved immediately, ' 'setting the approved revision to tip.')), Option('fixes', 'The bug this proposal fixes.', str), ListOption('review', short_name='R', type=unicode, help='Requested reviewer and optional type.')]
@Richard,
I thought it is not necessary to have self.commit_ message. strip() .encode( 'utf-8' ). plugins/ launchpad/ cmds.py, the option 'message' is type=unicode. plugins/ launchpad/ lp_propose. py, self.call_ webservice already use commit_ message= self.commit_ message.
You can refer below two pieces of code.
in bzrlib/
in bzrlib/
bzrlib/ plugins/ launchpad/ cmds.py
class cmd_lp_ propose_ merge(Command) :
help='Propose the merge on staging.'),
Option( 'message' , short_name='m', type=unicode,
help='Commit message.'),
Option( 'approve' ,
help=(' Mark the proposal as approved immediately, '
' setting the approved revision to tip.')),
Option( 'fixes' , 'The bug this proposal fixes.', str),
ListOption( 'review' , short_name='R', type=unicode,
help='Requested reviewer and optional type.')]
...
takes_options = [Option('staging',
bzrlib/ plugins/ launchpad/ lp_propose. py proposal( self):
initial_ comment = self.get_ comment( prerequisite_ branch) webservice(
self. source_ branch. lp.createMergeP roposal,
target_ branch= self.target_ branch. lp,
prerequisi te_branch= prereq,
initial_ comment= initial_ comment,
commit_ message= self.commit_ message, reviewers= reviewers,
review_ types=review_ types)
def create_
"""Perform the submission."""
...
mp = self.call_