Code review comment for lp:~sidnei/lazr-js/combo-service

Revision history for this message
Sidnei da Silva (sidnei) wrote :

Thanks for the review.

- CSS modules: I've updated the examples to inline them.
- Module dependencies: Only overlay was changed, to make the dependencies more explicit, the other changes were about adding 'skinnable'.
- Tests: they look very similar, you have to look a bit closer to notice the difference yeah. :)
- Y.get(): I didn't introduce any new one. But it would be nice to do a once-over and clear them all.

« Back to merge proposal