Bazaar Explorer

Code review comment for lp:~simon-kersey/bzr-explorer/add-bzrexec-tool

  1. add-bzrexec-tool
  2. Merge into trunk
Revision history for this message
Ian Clatworthy (ian-clatworthy) wrote :

Hi Simon,

This all looks ok to me. FWIW, your suggested test fails for me gumbling about ...

'QBzrRunDialog' object has no attribute 'init_button_status'.

That doesn't look like it's your fault though.

Before I merge this, I'd like slightly more detail on your plans. For example, are you planning to make "bzr-exec" a new kind inside tool_dialogs.py? Or a checkbox that only becomes active when the "Bazaar Command" kind is selected? If the latter, maybe we ought to model it that way inside the XML as well?

review: Needs Information

« Back to merge proposal