Code review comment for lp:~sinzui/launchpad/canonical-fonts-bug-435356

This is my branch to use the official canonical fonts. I thought this would
be a fix to a few CSS files, but I discovered that we have templates that
define CSS because we cannot guarantee that the CSS file will be served.
I updated the YUI stylesheets, which we must be mindful not to undo when
we update YUI.

    lp:~sinzui/launchpad/canonical-fonts-bug-435356
    Diff size: 299
    Launchpad bug: https://bugs.launchpad.net/bugs/435356
    Test command: None
    Pre-implementation: mt, beuno
    Target release: 3.10.1

= Use the official Canonical fonts =

At the moment users see different fonts depending on the OS used - humanist
(Vera Sans) on Ubuntu, neo-grotesque (Arial) on Mac or Windows. The global
font definition should be changed to use humanist typeface only.

The official CSS property is
    font-family: bitstream vera sans, dejavu sans, verdana, sans-serif;

Which might always be applied to body or *.

For most users, there will be no change because the 'sans-serif' rule was
selecting vera sans. Some users will see dejavu sans. Mac and Windows users
will see Verdana.

== Rules ==

    * Do a global find and replace of `font-family:[^;]+;` for the new string.
    * Locate all uses arial and fix the `font:` declaration

== QA ==

    * Visit edge and inspect the font of the page.
    * Verify it is bitstream vera sans, dejavu sans, verdana, sans-serif

The YUI changes are harder to test. I do not know where they are used.

== Lint ==

Linting changed files:
  lib/canonical/launchpad/icing/print.css
  lib/canonical/launchpad/icing/shipit.css
  lib/canonical/launchpad/icing/style.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/autocomplete.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/calendar.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/colorpicker.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/datatable.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/editor.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/logger.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/paginator.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/profilerviewer.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/simpleeditor.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/assets/skins/sam/skin.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/calendar/assets/skins/sam/calendar-skin.css
  lib/canonical/launchpad/icing/yui_2.7.0b/build/calendar/assets/skins/sam/calendar.css
  lib/canonical/launchpad/templates/launchpad-restrictedinfo.pt
  lib/canonical/launchpad/templates/launchpad-restrictedlogin.pt
  lib/canonical/launchpad/templates/oops-veryplain.pt

== Test ==

None. though as an after thought, I see that we were being asked to remove
[ ,:]arial[, ;] from all the styles. It only occurs in a slimmer/ test in
contrib.

== Implementation ==

Nothing much to say. I added namespaces to
lib/canonical/launchpad/templates/oops-veryplain.pt to quiet lint.