Code review comment for lp:~sinzui/launchpad/canonical-fonts-bug-435356

Revision history for this message
Gavin Panella (allenap) wrote :

Hi Curtis,

All looks good :)

I had a quick conversation with noodles about the YUI stuff which
might be interesting to you:

  <allenap> noodles775: Do you know where we use YUI 2.7?

  <noodles775> allenap: yep - the date/time picker :/

  <noodles775> allenap: see the inclusion in templates/sprint-new.pt for example.

  <allenap> noodles775: Thanks. By the way, it's in reference to
    https://code.edge.launchpad.net/~sinzui/launchpad/canonical-fonts-bug-435356/+merge/13318
    where sinzui has updated the font-family definitions in the YUI 2.7
    code. I wondered if it was necessary.

  <noodles775> allenap: right. fwiw, afaik we're only using yui2.7 for
    the calendar, so updating those two css files would be necessary,
    not sure about the others.

Gavin.

review: Approve (code)

« Back to merge proposal