Code review comment for lp:~sinzui/launchpad/delete-structural-target

Revision history for this message
Eleanor Berger (intellectronica) wrote :

We discussed changing obj.destroySelf to Store.of(obj).remove(obj) so that we don't add new sqlobject-oriented code.

Also, we agreed that keeping the deletion work in the view (rather than in the model) is a bit unfortunate (since we won't be able to repeat the same interaction when working with the model directly or via the API) but for now that's the pragmatic solution.

review: Approve (code)

« Back to merge proposal