Code review comment for lp:~sinzui/launchpad/front-page-footer-0

Revision history for this message
Curtis Hovey (sinzui) wrote :

I removed the trailing whitespace you pointed out.

On Fri, 2010-06-11 at 14:47 +0000, Abel Deuring wrote:
> > +.tour {
> > + background-image: url(/@@/tour-icon); /* needs-ref: */
> > + background-repeat: no-repeat;
> > + }
>
> I think "needs-ref" above is worth an XXX.

I added it to the sprite image. I intended to do this, but neglected to
followup

This is the order of steps to add to the sprite image.
1. Place the image in icing/ (we already had tour-icon)
2. Create a class like this:
   background-image: url(/@@/tour-icon); /* sprite-ref: icon-sprites */
   background-repeat: no-repeat;
3. make sprite_image
4. make sprite_css
5. make css_combine
6. make run.
7. verify you see the icon on the element
8. inspect the CSS applied to the element
   and verify that background-position was added.
9. commit the changes to the generated files.

--
__Curtis C. Hovey_________
http://launchpad.net/

« Back to merge proposal